Los Angeles, CA
LA, CA USA - Managua, Nicaragua
Comment by ~petersanchez on ~netlandish/links
Peter Sanchez referenced this ticket in commit 9ac75f7.
REPORTED
RESOLVED IMPLEMENTEDTicket created by ~petersanchez on ~netlandish/links
Why we did a 150 character limit is beyond me. This needs to be updated to say 300 or maybe more.
Comment by ~petersanchez on ~netlandish/links
This was completed here:
https://git.code.netlandish.com/~netlandish/links/commit/02c85f04f6867069e8f9f8296841f4a4a017b39d
REPORTED
RESOLVED IMPLEMENTEDtask added by ~petersanchez on ~netlandish/links
Ticket created by ~petersanchez on ~netlandish/links
It's possible that when attempting to fetch a saved bookmark that there is an error fetching the link metadata. Instead of trying to fetch it again right away we should create a process to automatically try again, periodically, and in bulk jobs.
My thinking is we have a job that runs every hour and processes say 1500 pending BaseURL's at a time. We will add 3 new fields to the
base_url
table.
error_count
- the number of times we've had an error fetching the urllast_error_date
- The last time we attempted to fetch the urlmetadata
- A JSONB array to store error messages and datesWe set a max limit to error count to say 3. The periodic task will look for entries that have
public_ready=false
, error count of greater than 0 and less than 3, and that the last error attempt happened 24+ hours ago. Then it will process it again and update the error date and error log if it fails again.After 3 error attempts we just never process that link again as it's probably a bad link or just not worth the continued effort.
task added by ~petersanchez on ~netlandish/links
bug added by ~petersanchez on ~netlandish/links
Ticket created by ~petersanchez on ~netlandish/links
The module has moved from
github.com/mattermost/mattermost-server
togithub.com/mattermost/mattermost/server
Also Mattermost apps have changed completely on the MM side.
Ref: #98
Ticket created by ~petersanchez on ~netlandish/links
In gobwebs, upgrading minio module to v7.0.87 (current latest) causes the build in links to fail:
# github.com/mattermost/mattermost-server/v6/shared/filestore ../../src/go/pkg/mod/github.com/mattermost/mattermost-server/v6@v6.6.0/shared/filestore/s3store.go:109:27: cannot use customProvider{…} (value of type customProvider) as credentials.Provider value in argument to credentials.New: customProvider does not implement credentials.Provider (missing method RetrieveWithCredContext) make: *** [Makefile:16: links] Error 1
I don't see why as I can't see where minio client is updating anything with the mattermost-code which depends on the aws sdk.
Either way I think mattermost needs to be updated to v10. See #99 for reference.
Comment by ~petersanchez on ~netlandish/links
Peter Sanchez referenced this ticket in commit 63b52bd.
REPORTED
RESOLVED FIXED