Los Angeles, CA
LA, CA USA - Managua, Nicaragua
Ticket created by ~petersanchez on ~netlandish/links
When paginating unread or starred lists the pagination is missing the filter option. This results in paginating all bookmarks instead of the filtered ones. Probably just a missing tag call.
Comment by ~petersanchez on ~petersanchez/django-impersonate
You don't need an account to submit a patch. See:
https://hg.code.netlandish.com/~petersanchez/django-impersonate#contributing
Patches are sent via
hg emailto the public mailing list here:https://lists.code.netlandish.com/~petersanchez/public-inbox
Thank you! I appreciate the help!
~Adam Taylor, Mar 28, 2025 at 20:00:
My understanding is that the SESSION_ENGINE setting doesn't affect this issue; it's the SESSION_SERIALIZER setting. The only session serializer that comes with Django is django.contrib.sessions.serializers.JSONSerializer and the documentation says "we highly recommend sticking with JSON serialization". That being the case, I think the best approach is to use isinstance(new_user.pk, uuid.UUID) to determine if the primary key should be cast to a string or not. I would submit a patch, but I don't have an account and it says that registration is closed.
-- View on the web: https://todo.code.netlandish.com/~petersanchez/django-impersonate/44#event-1240
Comment by ~petersanchez on ~petersanchez/django-impersonate
Hi Adam,
Did you test this with different session backends? I think that was the hold up reviewing the comments. I haven't had time to even touch this project in a while so if you've got some time to test this and submit a patch that would be greatly appreciated.
See the comment above from Christopher Baily for details.
feature added by ~petersanchez on ~netlandish/links
Ticket created by ~petersanchez on ~netlandish/links
Add a named tag grouping and/or filtering that would allow named links to provide the filters. For instance:
https://linktaco.com/org-slug/grouping-slug
It simply applies the filters to the org referenced.
Comment by ~petersanchez on ~netlandish/links
Thank you Gebhard. How would you envision the tag cloud to work? On the bookmark listing page for quicker filtering? A specific tag cloud page where all the tags are links to the corresponding bookmarks? Both maybe?
I know on Pinboard it's hosted on the bookmark listing page on the right column. I suppose we can do similar but just curious what you think is the best experience.
feature added by ~petersanchez on ~netlandish/links
bug added by ~petersanchez on ~netlandish/links
Ticket created by ~petersanchez on ~netlandish/links
Yes, "wonky" is a technical term.
I stumbled onto a couple of different logic situations for cursor pagination. In some cases the right order may be returned from the GraphQL API but the presentation is backwards. Usually the handler just needs to reverse the result list before populating the template.
However, I also noticed different ordering logic, etc. in different resolvers and this needs to be corrected. The logic should be the same in all cases.
Comment by ~petersanchez on ~petersanchez/django-impersonate
Thank you! You can use
hg emailto submit the patch to the mailing list. It's really simple to do, takes all of 20 seconds (if you've already got hg configured for email, otherwise it'll take you 60ish seconds heh). The instructions are here.The email for the list is
~petersanchez/public-inbox@lists.code.netlandish.com. Or if you'd rather just send it directly to me that's fine too (pjs@petersanchez.com)I really appreciate the help. I've so little time for this project at the moment.