Los Angeles, CA
LA, CA USA - Managua, Nicaragua
Comment by ~petersanchez on ~netlandish/links
Peter Sanchez referenced this ticket in commit 6d9a153.
REPORTED
RESOLVED IMPLEMENTEDtask added by ~petersanchez on ~netlandish/links
feature added by ~petersanchez on ~netlandish/links
Ticket created by ~petersanchez on ~netlandish/links
Review the
NewTagQuery
helper andTagQuery
struct that lives inlinks/helpers.go
. I am not sure why it's needed and why there was a decision to use subqueries here. This feels very inefficient and as the database continues to grow, I think this will just get slower and slower.There are probably a few things to review and see the best way to change it. I think first things first is simply adding
sq.Eq{"t.slug": tags}
andsq.NoEq...
The joins are already present on most cases. Maybe it's fine for listings and shorts but I think even there the main "Get" helper functions can simply be adjusted with a join and query change.
Comment by ~petersanchez on ~netlandish/links
Wow thanks! It is staying for sure!
Ticket created by ~petersanchez on ~netlandish/links
A new handler and resolver to show who all saved the same bookmark.
It should take the BaseURL hash ID and then display all public, or permission orgs, links that are linked to the same bookmark.
Comment by ~petersanchez on ~netlandish/links
Peter Sanchez referenced this ticket in commit 26fba77.
REPORTED
RESOLVED IMPLEMENTEDComment by ~petersanchez on ~netlandish/links
This has been added and pushed live. Let me know how it's working for you. I am watching for any errors etc as I work on unit tests for this but I wanted to get it live for real testing.
Comment by ~petersanchez on ~netlandish/links
Peter Sanchez referenced this ticket in commit a3b9037.
REPORTED
RESOLVED IMPLEMENTED